refactor: extends the input type of zonesNormalize function #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we have zones if we pass only exclusion zones? and the input zones is empty? |
|
What I care about is consistency. Please also do it in the other functions of the |
|
Also, this seems to be a breaking change (see failing tests) |
This method in particular can returns zones with an empty zones input. e.a const result = zonesNormalize([], {
from: 0,
to: 10,
exclusions: [{ from: 1, to: 2 }],
});this breaking change can be avoided by: if (zones.length === 0) {
zones.push({ from, to } as Zone);
} |
jobo322
force-pushed
the
refactor-zonesNormalize-05-11-2024-433
branch
from
43c84e9
to
289c587
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a package that use zonesNormalize but those zones has the structure:
{ id: string } & FromTo
so should be nice to refactor this function to accept those kind of inputs and preserve in this particular case the
id